Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build reference inside docker container #59

Open
nsyzrantsev opened this issue May 12, 2024 · 1 comment
Open

Build reference inside docker container #59

nsyzrantsev opened this issue May 12, 2024 · 1 comment
Labels
priority: medium steps/cdr3nt_error_corrector cdr3 error correction step steps/igblast igblast (cdr3 mapping and annotating) step steps/vidjil vidjil (cdr3 mapping) step

Comments

@nsyzrantsev
Copy link
Collaborator

nsyzrantsev commented May 12, 2024

The user does not always have all the tools, or his/her OS does not support these tools that are used in build_ref.sh. I think reference building should be done inside the docker container — this is necessary for reproducibility of the results.

@nsyzrantsev nsyzrantsev added steps/cdr3nt_error_corrector cdr3 error correction step steps/vidjil vidjil (cdr3 mapping) step steps/igblast igblast (cdr3 mapping and annotating) step labels May 12, 2024
@nsyzrantsev
Copy link
Collaborator Author

nsyzrantsev commented May 12, 2024

And I think we should rewrite these build_ref.sh scripts to the python scripts, because it is very difficult to catch errors inside bash.

To do:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority: medium steps/cdr3nt_error_corrector cdr3 error correction step steps/igblast igblast (cdr3 mapping and annotating) step steps/vidjil vidjil (cdr3 mapping) step
Projects
None yet
Development

No branches or pull requests

1 participant