Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Doc enhancement areas #1

Open
KooperL opened this issue Jul 29, 2024 · 2 comments
Open

Doc enhancement areas #1

KooperL opened this issue Jul 29, 2024 · 2 comments

Comments

@KooperL
Copy link

KooperL commented Jul 29, 2024

Nice project! Used it to get a POC online which consumes a 3rd party API. Have some feedback if you're open!

  1. Small typos - the website (not the readme) doesn't include the https:// protocol in the usage example of site to be proxied. Both usage examples also put the desired url variable into the path (api.cors.lol/url=blah) instead of query parameter (api.cors.lol?url=blah)
  2. The api I was consuming required it's query params of its own (https://baconipsum.com/api/?type=meat-and-filler). It seemed like the go's http lib was able to accommodate this by auto decoding a URL encoded variable (url=https%3A%2F%2Fbaconipsum.com%2Fapi%3Ftype%3Dmeat-and-filler). Could be worth mentioning this for free brownie points or go a step further and pass along a http data payload or set custom methods

Just small cosmetic suggestions at the end of the day. Happy to make a PR if you'd like

@BradPerbs
Copy link
Owner

Hi @KooperL I will fix the website soon thanks for the hint!

PR's are well appreciated 😃, if you do send the link over, I will be sure to mention you in the contributors.

@BradPerbs
Copy link
Owner

Fixed some of the issued. thanks for the feedback!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants