Move Delay Frames to Configurable Option in Brawlback Pane of Config

[WhiteTPoison]

There is currently a constant in brawlback-common/BrawlbackConstants.h that defines the amount of delay. I need this to be moved to an option configurable in the Brawlback config menu. The UI element is already there, I just need it to actually impact the amount of delay in the match. Default should be changed to 1.

Note: There is a separate issue for setting this in the game, do not worry about that. This is simply for hooking up the UI element to replace the constant.

[blasphemetheus]

https://github.com/Brawlback-Team/dolphin/blob/master/Source/Core/DolphinQt/Settings/BrawlbackPane.cpp line 91, the object in question is &BrawlbackPane:SaveSettings, which is line 133.

It uses an SConfig to hold state of the settings, a good alternative example of which is on https://github.com/Brawlback-Team/dolphin/blob/master/Source/Core/DolphinQt/Settings/GeneralPane.cpp line 341.

BrawlbackConstants.h is imported by two files in dolphin,

dolphin/Source/Core/Core/Brawlback/BrawlbackUtility.h

Line 20 in b3a62b2

#include "brawlback-common/BrawlbackConstants.h"

(BrawlbackUtility) and

dolphin/Source/Core/DolphinLib.vcxproj

Line 98 in b3a62b2

<ClInclude Include="Core\Brawlback\include\brawlback-common\BrawlbackConstants.h" />

(an xml file that i'm not sure about the details of)

Looks like what's needed is the FRAME_DELAY constant from BrawlbackConstants.h which is used by

dolphin/Source/Core/Core/Brawlback/TimeSync.cpp

Line 37 in b3a62b2

frameDiffCheck = frameDiff > FRAME_DELAY;

(TimeSync.cpp) and

dolphin/Source/Core/Core/HW/EXI/EXIBrawlback.cpp

Line 300 in b3a62b2

for (int i = GAME_START_FRAME; i < FRAME_DELAY; i++)

(EXIBrawlback.cpp) to be replaced with a reference to that setting from dolphin. Hold up I'll try and find an example of this elsewhere in the code

[blasphemetheus]

Delay Frames in BrawlbackPane appears to default to 2 as well, instead of 1, not sure why. Thought it might be an off by 1 error (0 to 1, so 1 to 2) but I see no evidence of that in the BrawlbackPane.cpp

[blasphemetheus]

https://github.com/Brawlback-Team/dolphin/blob/b3a62b2af6d955f0b3d3bafe669ca637707c2ce6/Source/Core/Core/ConfigManager.h
+
https://github.com/Brawlback-Team/dolphin/blob/b3a62b2af6d955f0b3d3bafe669ca637707c2ce6/Source/Core/Core/ConfigManager.cpp

is where SConfig is

AND

in ConfigManager.h line 64 it explicitly sets the delay to 2

[blasphemetheus]

I think what I'm getting from ConfigManager.h is that referenceds to the frame delay are accessed like so

const SConfig& settings = SConfig::GetInstance();
int frame_delay = settings.m_delayFrames;

and need to remember to change the default m_delayFrames in ConfigManager.h, but I think that's it

[blasphemetheus]

#58 PR