Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set MEM2 Memory Override to Max and Lockout User from Changing #54

Open
WhiteTPoison opened this issue Feb 25, 2024 · 3 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@WhiteTPoison
Copy link
Member

WhiteTPoison commented Feb 25, 2024

image

See above, the emulated memory size override needs to default to being on and the MEM2 needs to be locked at 128 MB. Lockout the user from changing MEM1 at all. If possible, make the 128 MB a constant set at build-time for futureproofing purposes.

@WhiteTPoison WhiteTPoison moved this to Todo in Brawlback Board Feb 25, 2024
@WhiteTPoison WhiteTPoison added enhancement New feature or request help wanted Extra attention is needed labels Feb 25, 2024
@blasphemetheus
Copy link

blasphemetheus commented Jun 26, 2024

mk, so there's layers of things I Don't understand, but https://github.com/Brawlback-Team/dolphin/blob/master/Source/Core/DolphinQt/Settings/AdvancedPane.cpp line 283

Something like

SignalBlocking(m_ram_overrid_checkbox)->set checked(Config::Get(Config::MAIN_RAM_OVERRIDE_ENABLE));

Making sure to include SignalBlocking.h a la GameCubePane.cpp

There's a whole logic about when to enable the ram_override_widgets that can be side-stepped and sort of adding below with

  • set checkbox to on (main ram override enable)
  • set mem1 slider to disabled (?)
  • set mem2 slider to a certain value
  • set mem2 slider to disabled

@blasphemetheus
Copy link

Not sure of the use of SignalBlocking as it's what's used in the gamecube pane, but the advanced pane uses QSignalBlocker to do a similar thing

@blasphemetheus
Copy link

#56 PR addressing this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants