Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Option for "guessed licenses" #49

Open
neverendingqs opened this issue Sep 5, 2017 · 5 comments
Open

Option for "guessed licenses" #49

neverendingqs opened this issue Sep 5, 2017 · 5 comments

Comments

@neverendingqs
Copy link
Member

Request: add an option that toggles matching for guessed licenses.

As per https://github.com/Brightspace/license-checker-ci/blob/master/bin/license-checker-ci?at=b5c57a7#L90 and:

An asterisk next to a license name means that it was deduced from an other file than package.json (README, LICENSE, COPYING, ...) You could see something like this:
~ https://github.com/davglass/license-checker/blob/master/README.md

the tool attempts to guess which licenses are used based on a file other than package.json.

Depending on the context, guessed licenses might be sufficient to satisfy licensing needs.

@jkehres
Copy link
Contributor

jkehres commented Sep 5, 2017

Should we really be "guessing" when it comes to license compliance?

@neverendingqs
Copy link
Member Author

It depends on how much you trust https://github.com/davglass/license-checker/blob/master/lib/license.js?r=f58b20c.

The current tool looks at package.json for "exact" checks, which doesn't necessarily have to be correct either. (To be fair, incorrect declarations in package.json could maybe be pushed back to the owner not declaring their license properly / IANAL).

@zommerfelds
Copy link
Contributor

I agree with Jeff, but newer contributors to this project seem to like less strict checking. If less maintenance work is desired than that is fine with me. It would be nice to have official D2L guidelines about what is OK to do for automated license checking.

@zommerfelds
Copy link
Contributor

For example we already made the assumption that minor version changes won't change the license.

@neverendingqs
Copy link
Member Author

Feel free to close this - I'm happy without this with #50 and #51 on the horizon.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants