feat(proxy): allow any node-http-proxy options via proxy.proxyOptions - fixes #430

Author: shakyShane

lib/server/proxy-server.js

@@ -39,6 +39,7 @@ function getOptions (bs, scripts) {
     var options  = bs.options;
 
     var snippetOptions = options.get("snippetOptions").toJS();
+    var proxyOptions  = options.getIn(["proxy", "proxyOptions"]);
     var rewrites = [snippetUtils.getRegex(options.get("snippet"), options.get("snippetOptions"))];
 
     if (bs.options.get("rewriteRules")) {
@@ -55,6 +56,10 @@ function getOptions (bs, scripts) {
         }
     };
 
+    if (proxyOptions) {
+        out.proxyOptions = proxyOptions.toJS();
+    }
+
     if (options.getIn(["proxy", "reqHeaders"])) {
         out.reqHeaders = options.getIn(["proxy", "reqHeaders"]);
     }

test/specs/e2e/proxy/e2e.proxy.proxy.options.js

@@ -0,0 +1,72 @@
+"use strict";
+
+var browserSync     = require("../../../../index");
+var testUtils       = require("../../../protractor/utils");
+var Immutable       = require("immutable");
+var request         = require("supertest");
+var assert          = require("chai").assert;
+var foxyPath        = require.resolve("foxy");
+var foxy            = require(foxyPath); // jshint ignore:line
+
+describe("E2E proxy test with `proxyOptions`", function () {
+
+    this.timeout(15000);
+
+    var bs, app, spy;
+
+    before(function (done) {
+
+        browserSync.reset();
+
+        app = testUtils.getApp(Immutable.Map({scheme: "https"}));
+
+        app.server.listen();
+
+        var config = {
+            proxy: {
+                target: "https://localhost:" + app.server.address().port,
+                proxyOptions: {
+                    xfwd: true
+                }
+            },
+            open: false,
+            logLevel: "silent"
+        };
+
+        spy = require("sinon").spy(require.cache[foxyPath], "exports");
+        bs = browserSync.init(config, done).instance;
+    });
+
+    after(function () {
+        bs.cleanup();
+        app.server.close();
+    });
+
+    it("sets options for node-http-proxy", function (done) {
+
+        assert.isTrue(spy.getCall(0).args[1].proxyOptions.xfwd); // check fn passed to foxy
+
+        spy.restore();
+
+        var expected = app.html.replace("BS", bs.options.get("snippet") + "BS");
+        var headers;
+        app.app.stack.unshift({
+            route: "/index.html",
+            handle: function (req, res, next) {
+                headers = req.headers;
+                next();
+            }
+        });
+
+        request(bs.options.getIn(["urls", "local"]))
+            .get("/index.html")
+            .set("accept", "text/html")
+            .expect(200)
+            .end(function (err, res) {
+                assert.ok(headers["x-forwarded-for"]);
+                assert.ok(headers["x-forwarded-port"]);
+                assert.equal(res.text, expected);
+                done();
+            });
+    });
+});