-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
--config does not take absolute path #583
Comments
Confirmed. Thanks for your detailed reporting, @xkxx. |
thanks @xkxx - but where is the PR ? :p |
I thought about it, but then thought it was too trivial to be worth a PR - hope I have provided enough info for you guys to fit it :) |
Nothing is too trivial for a PR :) |
Speaking of trivial PRs, would you mind taking a look at shakyShane/html-injector#5? |
Ahh yeah I saw that - it's on the list for the next round of bug fixes / pr's :) |
Hello,
Currently --config does not take absolute paths. For example, doing something like this throws an error:
This is caused by
browser-sync/lib/cli/cli-info.js:28
:Which tries to resolve relative url by prepending process.cwd(), but that's the job of
path.resolve
.Changing this line to the following does the correct thing, and fixes the issue:
Thanks,
Kexiang
The text was updated successfully, but these errors were encountered: