Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

cloudsql_maintenance rule miss non compliant instances #39

Closed
BrunoReboul opened this issue Nov 5, 2020 · 0 comments · Fixed by #40
Closed

cloudsql_maintenance rule miss non compliant instances #39

BrunoReboul opened this issue Nov 5, 2020 · 0 comments · Fixed by #40
Assignees
Labels
type: bug Error or flaw in code with unintended results
Milestone

Comments

@BrunoReboul
Copy link
Owner

BrunoReboul commented Nov 5, 2020

the current REGO rules looks for instance with a defined hour settings, but instance with no defined maintenance window appers now as;

                "maintenanceWindow": {
                    "day": 0,
                    "hour": 0,
                    "kind": "sql#maintenanceWindow"
                },

So day is a better setting to control instead of hour as dqys index is"

  • 0 maintenance window not defined
  • 1 Monday
  • 2 Tuesday
  • 3 Wednesday
  • 4 Thursday
  • 5 Friday
  • 6 Saturday
  • 7 Sunday

While hours index is:

  • 0 0am to 1am UTC
  • up to 23
@BrunoReboul BrunoReboul added the type: bug Error or flaw in code with unintended results label Nov 5, 2020
@BrunoReboul BrunoReboul added this to the 2020-10 milestone Nov 5, 2020
@BrunoReboul BrunoReboul self-assigned this Nov 5, 2020
This was referenced Nov 5, 2020
@BrunoReboul BrunoReboul linked a pull request Nov 5, 2020 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: bug Error or flaw in code with unintended results
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant