-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
SolidJS: migrate css
prop solution to solid-styled
#947
Comments
Hey @samijaber, I would like to contribute to this. (Sorry for the newbie questions, just needed a heads up if this is the correct approach) |
@akshatgarg12 I haven't had time to look: I am not familiar with the difference between both, so we'd need to read up the docs/API of both and see if there are differences between them, and go from there. I actually also see that |
Note to anyone who'll look into this. If possible, make the solution work on Solid components class="" rather than className="", because className quite likely could go away in future versions. Setups like clsx might come in handy. |
Please assign me, I will migrate css props to solid-styled. thanks |
@Syed-Bilal-Haider-Engineer go for it! |
Migrate our approach for the
css
prop in the SolidJS generator from using https://github.com/solidjs/solid-styled-components to using https://github.com/lxsmnsyc/solid-styled (as recommended by some folks in the SolidJS Community)The text was updated successfully, but these errors were encountered: