Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove redundant "Add or replace cooling tower" from Other HVAC #330

Closed
nllong opened this issue Apr 21, 2021 · 2 comments · Fixed by #331
Closed

Remove redundant "Add or replace cooling tower" from Other HVAC #330

nllong opened this issue Apr 21, 2021 · 2 comments · Fixed by #331
Assignees
@JieXiong9119
Labels
Breaking Change enhancement Schema: Measures Update to measures

Comments

@nllong
Copy link
Member

nllong commented Apr 21, 2021

There are two measures with "Add or replace cooling tower", one in Chiller Plant Improvements and one in Other HVAC.

Cooling towers should just exist in Chiller Plant Improvements.
@JieXiong9119
Copy link
Contributor

Should I open a new PR or include it into the PR with other three changes?

@nllong
Copy link
Member Author

nllong commented Apr 21, 2021

yep, with a proposal too (which will be really short).

@JieXiong9119 JieXiong9119 mentioned this issue Apr 21, 2021
Merged
@JieXiong9119 JieXiong9119 linked a pull request Apr 21, 2021 that will close this issue
Remove redundant "Add or replace cooling tower" #331
Merged
@nllong nllong closed this as completed May 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@JieXiong9119 JieXiong9119

Labels
Breaking Change enhancement Schema: Measures Update to measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant "Add or replace cooling tower" BuildingSync/schema
2 participants
@nllong @JieXiong9119