rename tracking for tree diffs #742
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Byron
force-pushed
the
rename-tracking
branch
9 times, most recently
from
e59da5a to
aefe955
Compare
These were formerly git.
These methods allow to easily access the current object id and mode of a change, as well as the mode separately.
Returns true if the entry points to a blob or a symlink.
…ilename()` builder method. That way, the recorder can be used in other applications to keep track of the full path *or* the filename.
…names only. Previously the recorder would track full paths, but now it's possible to configure it to track no paths or file names only. That way it's possible to use the implementation in custom delegate implementations or otherwise tune the computational cost according to actual needs.
Byron
force-pushed
the
rename-tracking
branch
from
aefe955 to
2c1ebd1
Compare
The invocation of `object::tree::diff::Platform::track_rewrites(Rewrites { percentage: None, ..Default::default() })`
is now able to explicitly configure perfect rename tracking without percentage of equivalence.
By setting `percentage = Some(<fraction>)` one can set how similar both files should be to be considered related.
The same can be configured for copy-tracking.
Note that by default, renames are considered if a file looks 50% similar, and copies tracking is
using the same convention.
Co-authored-by: Pascal Kuthe <pascal.kuthe@semimod.de>
Byron
force-pushed
the
rename-tracking
branch
from
2c1ebd1 to
e029259
Compare
Open
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
some validation to assure we treat the fractions similar to git.- accept that we don't treat it perfectly similarSee the PR with intermediate work: jmforsythe/Git-Heat-Map#6
Follow-up: #749
Special thanks to @pascalkuthe for his support and for listening to my ramblings while figuring things out.