Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Submission fasta reroute ick4 #197

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Conversation

jessicarowell
Copy link
Collaborator

Description

For multicontig fasta submission, add -M n -Z flags to table2asn if fasta contains multiple headers.
Change submission_ch after bakta process to replace original fasta with the annotated fasta for submission.
Also, emit .fna after RUN_BAKTA process.
Corrections to modules.config publishDirs and removes some extraneous publishDir commands within local modules (because they're already in modules.config).

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out?
    • Does it produce the expected outputs, given the inputs provided?
  • Have you conducted proper linting procedures?

    • Numpy formatted docstrings for functions
    • Comments explaining lines of code
    • Consistent and intuitive naming conventions for variables, functions, classes, methods, attributes, and scripts
    • Single empty line between class functions, two lines between non-class functions, and two lines between imports and code body
    • Camel case formatting for class names
  • Have you updated existing documentation (README.md, etc.) or created new ones within docs?

CDC Checks

  • Did you check for sensitive data, and remove any?
  • If you added or modified HTML, did you check that it was 508 compliant?

Are additional approvals needed for this change? If so, please mention them below:

Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below:

@jessicarowell jessicarowell added the bug Something isn't working label Apr 10, 2024
@jessicarowell jessicarowell self-assigned this Apr 10, 2024
@kyleoconnell kyleoconnell merged commit 4b66457 into dev Apr 10, 2024
1 check failed
@kyleoconnell kyleoconnell deleted the submission_fasta_reroute_ick4 branch April 10, 2024 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants