Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new case-studies in readme #262

Open
arpita0911patel opened this issue Feb 14, 2025 · 6 comments · May be fixed by #263
Open

Add new case-studies in readme #262

arpita0911patel opened this issue Feb 14, 2025 · 6 comments · May be fixed by #263
Assignees
Labels
enhancement New feature or request

Comments

@arpita0911patel
Copy link
Member

arpita0911patel commented Feb 14, 2025

Use Data Preprocess tool, to run two following case-studies and update visualization results based on that.

  1. Yellowstone River near Livingston, MT
    python -m ngiab_data_cli -i gage-06192500 --subset --start 2022-05-01 --end 2022-08-01 --forcings --realization --run

  2. Muddy River Below Clear Creek Near Cougar, WA
    python -m ngiab_data_cli -i gage-14216500 --subset --start 2020-02-09 --end 2020-02-22 --forcings --realization --run

@arpita0911patel arpita0911patel added the bug Something isn't working label Feb 14, 2025
@arpita0911patel arpita0911patel added enhancement New feature or request and removed bug Something isn't working labels Feb 14, 2025
@benlee0423
Copy link

benlee0423 commented Feb 15, 2025

Issues with Muddy River:

  1. Getting error message on both preprocessor creation and NGIAB run.
    WARNING: Groundwater flux larger than storage
  2. Running time is long , running t3.2xlarge EC2 instance.
    Serial run
	NGen::init: 5.11568
	NGen::simulation: 351.788
	NGen::routing: 15.3893

real	6m14.282s
user	6m17.378s
sys	0m31.458s

Parallel run

NGen top-level timings:
	NGen::init: 4.33653
	NGen::simulation: 138.625
	NGen::routing: 26.1143

real	2m49.894s
user	14m11.612s
sys	3m53.370s
  1. Size is too big as sample data.
    -rw-rw-r-- 1 ubuntu ubuntu 572M Feb 15 00:45 AWI-gage-06192500_009.tar.gz
    -rw-rw-r-- 1 ubuntu ubuntu 3.1M Feb 15 00:47 AWI-gage-14216500_010.tar.gz

Yellowstone River data runs fast in both serial and parallel run on the same EC2 instance

@benlee0423
Copy link

benlee0423 commented Feb 15, 2025

wget https://ciroh-ua-ngen-data.s3.us-east-2.amazonaws.com/AWI-009/AWI-gage-06192500_009.tar.gz
wget https://ciroh-ua-ngen-data.s3.us-east-2.amazonaws.com/AWI-010/AWI-gage-14216500_010.tar.gz

@arpita0911patel
Copy link
Member Author

@JoshCu please take alook at first issue above that says WARNING message.

@benlee0423
Copy link

@arpita0911patel
Before we move forward, I recommend to reduce the size of Muddy River data adjusting start and end date because it is too big for the sample data. The WARNING message maybe related to the size.

@JoshCu
Copy link
Collaborator

JoshCu commented Feb 17, 2025

If you want to reduce the file size but keep the date range the same, most of the size is in this raw gridded data file. It's just a local copy of the remote retrospective data, it could be re-downloaded if needed. It's kind of a temporary file, I just keep it around so forcings can be recalculated faster.
Image

And that warning is coming from here https://github.com/NOAA-OWP/cfe/blob/17b39cb2f95b648efeaef4de731aca8a39f4db5a/src/cfe.c#L220 . My guess would be that the initial conditions of the simulation have way too much groundwater, more than should be possible, so the excess gets deleted by cfe.
That is just a guess though, based on this spike at the beginning of most of the uncalibrated simulations.

Image

@benlee0423
Copy link

benlee0423 commented Feb 18, 2025

@arpita0911patel
Yellowstone River near Livingston, MT is not actually Yellowstone.

Issue description is wrong.
Here is correct gage id

Yellowstone River near Livingston, MT - 06192500
Muddy River Below Clear Creek Near Cougar, WA - 14216500

Here is updated version.

Yellowstone River near Livingston, MT
python -m ngiab_data_cli -i gage-06192500 --subset --start 2022-05-01 --end 2022-08-01 --forcings --realization --run

Muddy River Below Clear Creek Near Cougar, WA
python -m ngiab_data_cli -i gage-14216500 --subset --start 2020-02-09 --end 2020-02-22 --forcings --realization --run

So, we can only add Muddy River, WA to README, and Yellowstone River is the one having issues.
Here is what I will do.

  1. Remove AWI-007 from README.
  2. Add Muddy River and it will be AWI-009.
  3. Add Case study for Muddy River in README.

@benlee0423 benlee0423 linked a pull request Feb 18, 2025 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants