Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add documentation #68

Open
benjamincjackson opened this issue Jun 12, 2020 · 4 comments · Fixed by #76
Open

Add documentation #68

benjamincjackson opened this issue Jun 12, 2020 · 4 comments · Fixed by #76
Labels
documentation Improvements or additions to documentation

Comments

@benjamincjackson
Copy link
Collaborator

No description provided.

@benjamincjackson benjamincjackson added the documentation Improvements or additions to documentation label Jun 12, 2020
@benjamincjackson benjamincjackson linked a pull request Jul 1, 2020 that will close this issue
@daveuu
Copy link

daveuu commented Jul 3, 2020

"Samples in different phylotypes share mutations with other sequences in the data set. An exception to this rule is that samples with different phylotypes may share a mutation if that mutation is a homoplasy (i.e. it arose multiple times on the tree)"

Is there a "not" missing in the first sentence above? Last section here: https://github.com/COG-UK/grapevine/blob/master/docs/lineages.md

@jtmccr1
Copy link
Contributor

jtmccr1 commented Jul 3, 2020

I don't think so, but the wording is confusing. Bringing in the line above it, would this be more clear?
"Samples that have the same phylotypes are allowed differ from each other only by unique mutations. Samples in different phylotypes differ by at least one mutation found elsewhere in the data set."
We're trying to say the same thing two different ways, but that may be doing more harm than good. I'm happy just to have the first sentence if that is clear enough.

@daveuu
Copy link

daveuu commented Jul 6, 2020

Personally, the phrase "elsewhere in the dataset" might be confusing me - it seems a bit non-specific. Is this wording accurate (if not clear)?:
"Samples of the same phylotype are allowed to differ from each other only by unique mutations. Samples in different phylotypes differ by at least one mutation found only in their respective phylotypes."

@jtmccr1
Copy link
Contributor

jtmccr1 commented Jul 6, 2020

I like this much better.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants