Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: rsv1 error #225

Merged
merged 7 commits into from
Feb 21, 2023
Merged

fix: rsv1 error #225

merged 7 commits into from
Feb 21, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented Feb 21, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri merged commit 0954d84 into main Feb 21, 2023
@cameri cameri deleted the fix/rsv1_error branch February 21, 2023 05:37
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

github-actions bot pushed a commit that referenced this pull request Feb 21, 2023
## [1.22.6](v1.22.5...v1.22.6) (2023-02-21)

### Bug Fixes

* rsv1 error ([#225](#225)) ([0954d84](0954d84))
@github-actions
Copy link

🎉 This PR is included in version 1.22.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

brandonrobinson5060 pushed a commit to VIDA-Global/nostream that referenced this pull request Feb 22, 2023
* chore: remove secret

* chore: allow lightningtipbot pubkey for zaps

* chore: add cloudflare remoteipheader

* chore: close client conn on error

* chore: terminate conn w/o subs

* chore: enable permessage-deflate

* fix: start logs
brandonrobinson5060 pushed a commit to VIDA-Global/nostream that referenced this pull request Feb 22, 2023
@h3ll0ofr1end
Copy link

Hello there,
running a relay for several days (v1.22.6) and the RSV1 showed up for the first time.

Schermata 2023-02-28 alle 20 00 37

Attach a copy of the log:

uncaught error: RangeError: Invalid WebSocket frame: RSV1 must be clear
nostream          |     at Receiver.getInfo (/app/node_modules/ws/lib/receiver.js:199:14)
nostream          |     at Receiver.startLoop (/app/node_modules/ws/lib/receiver.js:146:22)
nostream          |     at Receiver._write (/app/node_modules/ws/lib/receiver.js:84:10)
nostream          |     at writeOrBuffer (node:internal/streams/writable:392:12)
nostream          |     at _write (node:internal/streams/writable:333:10)
nostream          |     at Writable.write (node:internal/streams/writable:337:10)
nostream          |     at Socket.socketOnData (/app/node_modules/ws/lib/websocket.js:1274:35)
nostream          |     at Socket.emit (node:events:513:28)
nostream          |     at addChunk (node:internal/streams/readable:324:12)
nostream          |     at readableAddChunk (node:internal/streams/readable:297:9) {
nostream          |   code: 'WS_ERR_UNEXPECTED_RSV_1',
nostream          |   [Symbol(status-code)]: 1002
nostream          | }

@pgerstbach
Copy link

Same here, multiple occurrences this night altough being on the latest version!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants