Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: lnbits broken after lnurl-pay support #310

Merged
merged 1 commit into from
May 19, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 19, 2023

Description

  1. Fix getting invoice from payment processor when given an lnbits invoice's payment hash

Related Issue

#306

Motivation and Context

LNURL-Pay support broke getting lnbit's invoice given a payment hash

How Has This Been Tested?

JohnOnChain kindly tested this branch and confirmed the fix worked.

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue May 19, 2023 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

@cameri cameri self-assigned this May 19, 2023
@cameri cameri merged commit 018f9a1 into main May 19, 2023
@cameri cameri deleted the 306-bug-lnbits-is-no-longer-working-in-version-123 branch May 19, 2023 14:10
github-actions bot pushed a commit that referenced this pull request May 19, 2023
## [1.24.1](v1.24.0...v1.24.1) (2023-05-19)

### Bug Fixes

* lnbits broken after lnurl-pay support ([#310](#310)) ([018f9a1](018f9a1))
@github-actions
Copy link

🎉 This PR is included in version 1.24.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Lnbits is no longer working in version 1.23
1 participant