Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat!: remove nip-26 delegation support #350

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

cameri
Copy link
Owner

@cameri cameri commented Jan 12, 2024

Description

Remove support for NIP-26 Delegation.

Related Issue

None

Motivation and Context

The current usage of NIP-26 does not merit the performance loss incurred for all queries and inserts.

How Has This Been Tested?

  1. Unit tests
  2. Integration tests
  3. Sending events to a live Nostream instance

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2024

Pull Request Test Coverage Report for Build 7497305858

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.7%) to 53.542%

Totals Coverage Status
Change from base Build 7496762592: -1.7%
Covered Lines: 1216
Relevant Lines: 2228

💛 - Coveralls

@cameri cameri force-pushed the chore/remove-nip-26-delegation-support branch from 91a463f to 8383118 Compare January 12, 2024 02:50
@cameri cameri changed the title chore: remove nip-26 delegation support feat!: remove nip-26 delegation support Jan 12, 2024
@cameri cameri requested a review from imksoo January 12, 2024 02:54
BREAKING CHANGE: NIP-26 support has been removed. Delegated events will not be handled differently.
@cameri cameri force-pushed the chore/remove-nip-26-delegation-support branch from 8383118 to 64f5616 Compare January 12, 2024 21:05
Copy link

@cameri cameri merged commit 6760ab0 into main Jan 12, 2024
@cameri cameri deleted the chore/remove-nip-26-delegation-support branch January 12, 2024 21:12
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
# [2.0.0](v1.26.0...v2.0.0) (2024-01-12)

* feat!: remove nip-26 delegation support (#350) ([6760ab0](6760ab0)), closes [#350](#350)

### BREAKING CHANGES

* NIP-26 support has been removed. Delegated events will not be handled differently.
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
# [2.0.0](v1.26.0...v2.0.0) (2024-01-12)

* feat!: remove nip-26 delegation support (#350) ([6760ab0](6760ab0)), closes [#350](#350)

### BREAKING CHANGES

* NIP-26 support has been removed. Delegated events will not be handled differently.
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
# [2.0.0](v1.26.0...v2.0.0) (2024-01-12)

* feat!: remove nip-26 delegation support (#350) ([6760ab0](6760ab0)), closes [#350](#350)

### BREAKING CHANGES

* NIP-26 support has been removed. Delegated events will not be handled differently.
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants