[Optimization] Main CICD pipeline, don't display deploy
warning when only synth
ing
#87
Open
1 of 2 tasks
Labels
enhancement
New feature or request
Is your feature request related to a problem? Please describe.
Just be more clear to users, and what the pipeline is thinking. Displaying a warning that's irrelevant can be confusing.
Describe the solution you'd like
Only show the warning on deploy.
Originally I didn't want to because it adds extra complexity to the
setup-matrix.setup-deploy
step, BUT I think it'll work out if I just create another step under that one. It can have an output that goes straight to the deploy-base input.With this,
setup-matrix
won't just be for matrix's any more. And setup in both the job and step is redundant anyways. Change to something like:setup.synth-matrix
,setup.deploy-matrix
, andsetup.should-deploy
. (That finalsetup.should-deploy
has the warning, because at that point it'd have all the variables to know if it should print it or not. Plus that job always runs, so it'd always be checked.)Describe alternatives you've considered
Leave it as is I guess...
Acknowledgements
The text was updated successfully, but these errors were encountered: