Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[enhancement] table - simplify usage #245

Closed
CanerCap opened this issue Nov 9, 2021 · 0 comments · Fixed by #284
Closed

[enhancement] table - simplify usage #245

CanerCap opened this issue Nov 9, 2021 · 0 comments · Fixed by #284
Labels
enhancement New feature or request
Milestone

Comments

@CanerCap
Copy link
Collaborator

CanerCap commented Nov 9, 2021

As a developer

I want to be able use the Table component with ease

so that I can easily import it into my react projects

Table currently receives the below props, we need to reduce the number of props required in order to use this components

IMPORTANT: Please retain pre-existing functionality and add additional properties if needed.

  1. Currently, to pass customHeaderLabels into a Table, you need to pass in an array of object with the following properties.
  customHeaderLabels={[
    { label: 'Test', data: 'id' },
    { label: 'position', data: 'position' },
    { label: 'name', data: 'name' },
    { label: 'weight', data: 'weight' },
    { label: 'symbol', data: 'symbol' },
    { label: 'actions', data: 'actions' },
  ]}

We would like to offer the developer using FormGroup the ability to add items with the same label and value like so:

customHeaderLabels={['Test', 'position', 'weight', 'symbol', 'actions'] }

data should be derived from a default value e.g. test-1 for the Test customHeaderLabel

  1. columnsToOmit={['symbol']} could be provided along side the customHeaderLabel in the customHeaderLabels array

Important: please use release/0.4 as base branch

@CanerCap CanerCap added the enhancement New feature or request label Nov 9, 2021
@CanerCap CanerCap self-assigned this Nov 9, 2021
@daniele-zurico daniele-zurico added this to the 0.4 milestone Nov 9, 2021
@Ibabalola Ibabalola linked a pull request Apr 19, 2022 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants