Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Autocomplete is not non-js compliant #276

Closed
Ibabalola opened this issue Mar 23, 2022 · 1 comment
Closed

Autocomplete is not non-js compliant #276

Ibabalola opened this issue Mar 23, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Ibabalola
Copy link
Contributor

Ibabalola commented Mar 23, 2022

The Autocomplete component doesn't work if javascript is disabled.

To make it work when js is disabled we need to turn the component into a select.

To disable Javascript on your chrome browser please refer to the following guide

Please refer to accessible-autocomplete for a working example

It also doesn't allow to:

  • to specify a class for the container
  • to specify a label
  • to specify a label class Name
  • to pass an id to the input or select element(in case of progressive enhancement)
  • to display an error message in three different positions (BEFORE_LABEL, BOTTOM, AFTER_LABEL and AFTER_HINT)
  • error message text
  • error className
  • error id

Please create your branch from release/0.5

git checkout release/0.5
git pull
git checkout -b 'feature/autocmplete-nonJs'
@Ibabalola Ibabalola added the enhancement New feature or request label Mar 23, 2022
@Ibabalola Ibabalola modified the milestones: 0.4, 0.5 Mar 24, 2022
@mmirca mmirca self-assigned this Jun 29, 2022
@daniele-zurico
Copy link
Contributor

closed with #307

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants