Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tabs is not non-js compliant #283

Closed
Ibabalola opened this issue Mar 24, 2022 · 2 comments
Closed

Tabs is not non-js compliant #283

Ibabalola opened this issue Mar 24, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Ibabalola
Copy link
Contributor

Ibabalola commented Mar 24, 2022

Tabs is not non-js compliant, with js turn off contents of all tabs do not display

To disable Javascript on your chrome browser please refer to the following guide

Please create your branch from release/0.7

git checkout release/0.7
git pull
git checkout -b 'feature/tab-nonJs'

Describe the solution you'd like
tabs should be able to work without javascript enabled current it doesn't

@Ibabalola Ibabalola added the enhancement New feature or request label Mar 24, 2022
@Ibabalola Ibabalola modified the milestones: 0.4, 0.5 Mar 24, 2022
@daniele-zurico daniele-zurico modified the milestones: 0.5, 0.6 Jul 25, 2022
@daniele-zurico
Copy link
Contributor

@brightpixels can you please confirm if this ticket is still needed?

@daniele-zurico daniele-zurico removed this from the 0.6 milestone Dec 20, 2022
@daniele-zurico daniele-zurico added this to the 0.7 milestone Jan 17, 2023
@cg-julian-taylor
Copy link
Collaborator

I've been given the recommendation to look at the tabs behaviour in GDS component library. The non JS approach they use is to list all the tabs as links and then put all the tab contents underneath each other.

I will code the layout to match this approach as long as that is ok with everyone else.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants