Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Autocomplete (js-mode): no results found should be part of the drop down list #322

Closed
brightpixels opened this issue Jul 20, 2022 · 1 comment
Closed

Autocomplete (js-mode): no results found should be part of the drop down list #322

brightpixels opened this issue Jul 20, 2022 · 1 comment
Assignees
@daniele-zurico
Labels
bug Something isn't working
Milestone
0.5

Comments

@brightpixels
Copy link
Collaborator

Describe the bug
We can set the 'no results found' via the notFoundText but it should show up in the same ul of the results list as an li

To Reproduce
Steps to reproduce the behavior:

  1. Use autocomplete in a React app and search for something that doesn't exsist.

Expected behavior
See screenshot

Screenshots
PixelSnap 2022-07-20 at 11 56 27

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A
@daniele-zurico daniele-zurico added the bug Something isn't working label Jul 20, 2022
@daniele-zurico daniele-zurico self-assigned this Jul 20, 2022
@daniele-zurico daniele-zurico added this to the 0.5 milestone Jul 20, 2022
@daniele-zurico daniele-zurico mentioned this issue Jul 20, 2022
Merged
@daniele-zurico
Copy link
Contributor

closed by #323

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@daniele-zurico daniele-zurico

Labels
bug Something isn't working
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@daniele-zurico @brightpixels