Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Group and Radio are confusing names #353

Closed
8 tasks done
daniele-zurico opened this issue Oct 7, 2022 · 1 comment
Closed
8 tasks done

Group and Radio are confusing names #353

daniele-zurico opened this issue Oct 7, 2022 · 1 comment
Assignees
Labels
new component new component
Milestone

Comments

@daniele-zurico
Copy link
Contributor

daniele-zurico commented Oct 7, 2022

Screenshot 2022-10-07 at 13 23 40

Screenshot 2022-10-07 at 13 23 40

  • Radio doesn't make sense to exist on his own because you'll never have a radio with one element. So actions are:

  • Remove the storybook documentation for radio

  • DO NOT Remove the FormRadio component however on top put a comment saying that this is deprecated and will not be used anymore

  • Form instead will be split into 2 components. So actions are:

  • Create a new Component called FormRadio (that is exactly the same as the Group with the only difference being that type will be hardcoded with the value of radio, i.e. type=radio

  • Create the documentation called FormRadio in storybook

  • Create a new Component called FormCheckbox (that is exactly the same of Group with the only difference being that type will be hardcoded with the value of checkbox, i.e. type=checkbox

  • Create the documentation called FormCheckbox in storybook

  • Remove the storybook documentation called Group

  • Remove the component called Group

This ticket is pretty much a refactor that will simplify the usage

Please follow the following instruction to create the new branch:

git checkout release/0.6
git pull
git checkout -b 'feature/radio-and-checkbox'
@daniele-zurico daniele-zurico added the new component new component label Oct 7, 2022
@daniele-zurico daniele-zurico added this to the 0.6 milestone Oct 7, 2022
@cg-julian-taylor cg-julian-taylor self-assigned this Dec 14, 2022
@daniele-zurico
Copy link
Contributor Author

closed by #380

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
new component new component
Projects
None yet
Development

No branches or pull requests

3 participants