Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Blockquote - Design System #531

Closed
cg-mmirca opened this issue Sep 22, 2023 · 1 comment
Closed

Blockquote - Design System #531

cg-mmirca opened this issue Sep 22, 2023 · 1 comment
Assignees
Milestone

Comments

@cg-mmirca
Copy link
Collaborator

Prerequisites

  • Abbreviate element will have the .dcx-blockquote class name

Overview

Possible states:

  • Default

Variants:
No variants

Keeping in mind we have the elements:

Element Description  Token Name
Text The text itself, should match regular body styles  body
Box The box containing the blockquote, it's common to have a display block with padding  blockquote_box

Storybook

Create the pages for:

  • Playground
  • Default
  • AccessibleTheme
  • DarkTheme
  • MaterialTheme

On each MDX page make examples for:

  • Default blockquote

Token definition

Considerations:

  • Take as reference the Paragraph component
  • Add the tokens to src/design-system/tokens.json
  • Define all styles in src/design-system/blockquote.css
  • Add import to the new CSS file in src/design-system/index.css

Possible tokens:

  • color-text-body
  • font-family-body
  • font-weight-body
  • font-size-body
  • spacing-x-blockquote_box
  • spacing-y-blockquote_box
  • etc.

Follow the naming pattern:

[token_category]-[property]-[element]-[variant]-[state]

F.e. for font-size-body we have:

  • category: font
  • property: size
  • element: body
  • variant: default -> not necessary to show in name
  • state: default -> not necessary to show in name

Please follow these steps to create your branch:

git checkout release/1.0.0
git pull
git checkout -b 'feature/ds-blockquote'
@jgonza16
Copy link
Collaborator

closed with #571

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants