Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tab group is displaying incorrect CSS #565

Closed
alexwbbr opened this issue Oct 31, 2023 · 2 comments
Closed

Tab group is displaying incorrect CSS #565

alexwbbr opened this issue Oct 31, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alexwbbr
Copy link
Collaborator

alexwbbr commented Oct 31, 2023

Following the example from the tabgroup stotybook docs: https://main--6069a6f47f4b9f002171f8e1.chromatic.com/?path=/docs/dcxlibrary-tabs-documentation--docs, which also has some mistakes such as disabledClassTab and onClick not being properties, once this is rendered I am noticing two instances of "tab-class-name" on the tabs element.
Screenshot 2023-10-31 at 11 03 44

I think this is coming from the Tab component className property.

follow this steps to create your branch:

git checkout release/1.0.0
git pull
git checkout -b 'but/tab-documentation'
@daniele-zurico
Copy link
Contributor

daniele-zurico commented Nov 2, 2023

in the example docs:

<TabGroup
  activeTabClassName="tab-active-class"
  id="tab-label-id"
  activeKey="tab label"
  disabledClassTab="disabled-class-name"   <----
  className="class-name"
  containerClassName="container-class-name"
  contentClassName="content-class-name"
  tabClassName="tab-class-name" <----
  onClick={onChangeHandler}  <----
>
  <Tab
    label="tab label"
    eventKey="tab-id"
    disabled={false}
    className="tab-class-name"
  >
    This the content for tab
  </Tab>
</TabGroup>

to:

<TabGroup
  activeTabClassName="tab-active-class"
  id="tab-label-id"
  activeKey="tab label"
  disabledClassName ="disabled-class-name"   <----
  className="class-name"
  containerClassName="container-class-name"
  contentClassName="content-class-name"
  tabClassName="common-tab-class" <----
  onSelect ={onChangeHandler}  <----
>
  <Tab
    label="tab label"
    eventKey="tab-id"
    disabled={false}
    className="tab-class-name"
  >
    This the content for tab
  </Tab>
</TabGroup>

@daniele-zurico daniele-zurico added the bug Something isn't working label Nov 2, 2023
@daniele-zurico daniele-zurico modified the milestones: 1.1.0, 1.0.0 Nov 2, 2023
@AlaaEddine20 AlaaEddine20 self-assigned this Nov 13, 2023
@daniele-zurico
Copy link
Contributor

closed by #569

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants