Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Checkbox Group - Design System #579

Closed
mmirca opened this issue Dec 1, 2023 · 1 comment
Closed

Checkbox Group - Design System #579

mmirca opened this issue Dec 1, 2023 · 1 comment
Assignees
Milestone

Comments

@mmirca
Copy link
Collaborator

mmirca commented Dec 1, 2023

Checkbox Group - Design System

1 - Prerequisites

  • Host element will have the .dcx-checkbox-group class name
  • Host element will have conditional classes for error state .dcx-checkbox-group--error class name

2 - Overview

2.1 - Possible states

Name Description
Default Instance without specific properties defined
Disabled Instance with native input disabled
Filled (Checked) Instance with value
Focus Instance while receiving focus on native input
Error Instance with validation errors

2.2 - Variants

Name Description
Default Default look & feel

2.3 - Structure

Element Description  Token Name
InputBox The native input itself  formcontrol
Label The label element  formcontrol_label

When developing take a close look to the FormSelect component. It is a form element as well, the tokens and styling approach should be similar.

2.4 - Tokens definition

Considerations:

  • ❗ Take a close look to the FormSelect component. It is a form element as well, the tokens and styling approach should be similar.
  • Add the tokens to src/design-system/tokens.json
  • Define all styles in src/design-system/checkbox.css
  • Add import to the new CSS file in src/design-system/index.css

Possible tokens:

  • color-text-formcontrol
  • color-text-formcontrol-error
  • color-text-formcontrol-filled
  • color-text-formcontrol_label
  • color-text-formcontrol_label-filled
  • color-text-formcontrol_label-error
  • etc.

Follow the naming pattern

3 - Storybook

Create the pages for:

  • Playground
  • Default
  • AccessibleTheme
  • DarkTheme
  • MaterialTheme

On each MDX page make examples for each possible variant

4 - Initial setup

Please follow these steps to create your branch:

git checkout release/1.0.0
git pull
git checkout -b 'feature/checkbox-group-design-system'
@cg-mmirca cg-mmirca changed the title Checkbox - Design System Checkbox Group - Design System Jan 11, 2024
@daniele-zurico daniele-zurico added this to the 1.0.0 milestone Feb 19, 2024
@jgonza16 jgonza16 self-assigned this Mar 16, 2024
@daniele-zurico
Copy link
Contributor

closed by #605

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants