Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FormRadio and FormInput Component does not offer a capability to not add an aria-label #621

Closed
Ibabalola opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
a11y a11y
Milestone

Comments

@Ibabalola
Copy link
Contributor

Ibabalola commented Apr 11, 2024

Describe the bug
Form Radio takes name as an aria-label when one is not provided however I need the aria-label attribute to be deleted as it
overrides the visible label and the already existing programmatic association between the
and the negates the need for an aria-label.

Expected behavior
When the aria-label property is not provided do not add it to the radio

Line 45 in the src/formRadio/FormRadio.tsx file
ariaLabel={ariaLabel || name}

@Ibabalola Ibabalola self-assigned this Apr 11, 2024
@Ibabalola Ibabalola added the a11y a11y label Apr 11, 2024
@Ibabalola Ibabalola added this to the 1.0.0 milestone Apr 11, 2024
@Ibabalola Ibabalola changed the title FormRadio Component does not offer a capability to not add an aria-label FormRadio and FormInput Component does not offer a capability to not add an aria-label Apr 12, 2024
@daniele-zurico
Copy link
Contributor

closed by #622

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
a11y a11y
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants