Skip to content

Collapse animation time is global rather than per-instance #163

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
CarlosNZ opened this issue Feb 6, 2025 · 0 comments · Fixed by #164
Closed

Collapse animation time is global rather than per-instance #163

CarlosNZ opened this issue Feb 6, 2025 · 0 comments · Fixed by #164
Assignees
@CarlosNZ
Labels
bug Something isn't working should do

Comments

@CarlosNZ
Copy link
Owner

CarlosNZ commented Feb 6, 2025

Describe the bug
Collapse animation time is global rather than per-instance. This is because it is using a CSS variable, which is updated at the document root.

Expected behavior
Each instance of JRE should be able to have its own collapse time
@CarlosNZ CarlosNZ added the bug Something isn't working label Feb 6, 2025
@CarlosNZ CarlosNZ self-assigned this Feb 6, 2025
@CarlosNZ CarlosNZ mentioned this issue Feb 7, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@CarlosNZ CarlosNZ

Labels
bug Something isn't working should do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#163 Make collapse time local CarlosNZ/json-edit-react
1 participant
@CarlosNZ