Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Command doesn't support && #4

Open
emcniece opened this issue Mar 13, 2017 · 2 comments
Open

Command doesn't support && #4

emcniece opened this issue Mar 13, 2017 · 2 comments

Comments

@emcniece
Copy link
Member

emcniece commented Mar 13, 2017

It would be nice to be able to chain a few commands, ie. nginx -t && service nginx reload.

INFO[0181] [rgon-exec -name=rgon-proxy-nginx-1 -cmd="nginx -t && service nginx reload"]: "Executing [nginx -t && service nginx reload] on container [rgon-proxy-nginx-1]"
INFO[0181] [rgon-exec -name=rgon-proxy-nginx-1 -cmd="nginx -t && service nginx reload"]: "nginx: invalid option: \"&&\"\r"
INFO[0181] [rgon-exec -name=rgon-proxy-nginx-1 -cmd="nginx -t && service nginx reload"]: "websocket: close 1000 (normal)"
DEBU[0181] Notify cmd output: "Executing [nginx -t && service nginx reload] on container [rgon-proxy-nginx-1]\nnginx: invalid option: \"&&\"\r\nwebsocket: close 1000 (normal)\n"
@Munsio
Copy link
Member

Munsio commented Mar 14, 2017

nginx -t should be used in the check-cmd on the staging file described in the rgon-rancher-gen so yeah in generally it would be nice to have && support but especially for nginx -t this shouldn't be in the rgon-exec

@emcniece
Copy link
Member Author

Great point. Our recent efforts with notify-lbl let us do this on check-cmd now too!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants