Remove CameraFlightPath.createAnimationCartographic

[pjcozzi]

As discussed with @bagnell, this can be replaced by the CameraFlightPath constructor function once it handles the scene mode correctly.

[pjcozzi]

Likewise, setPositionCartographic and friends should not be needed.

[bagnell]

@pjcozzi Why would we remove setPositionCartographic? We could make the camera use getters/setters and do the conversions automatically when set to a cartographic.

[pjcozzi]

Can't that just be a Cartesian3 like this change? It is core Camera work so if we do it, it can be a separate pull request.

[pjcozzi]

This is good. Merging.

@bagnell what is the plan for setPositionCartographic?

[bagnell]

So have a setPosition function that sets the position property based on the scene mode?

[pjcozzi]

Right, but a getter/setter property.

[pjcozzi]

@bagnell what is the plan here?

[bagnell]

I don't want to move the code to the position property because it does more than set the position. It also sets the orientation to look down at the Earth and orients up do be toward north. I can change all of the Camera properties to be getters/setters that are scene mode independent like the recent change for the transform

[pjcozzi]

Sounds good. Will leave this open.

[pjcozzi]

@bagnell is this something @hpinkos can help with?

[pjcozzi]

@bagnell is this something @hpinkos can help with?

?

[mramato]

According to @bagnell this won't make 1.0; so if/when we remove it; we'll have to go through deprecation.

[bagnell]

CameraFlightPath.createAnimationCartographic was removed. The issue here is now to remove the set cartographic functions from the camera. I'll write up another issue with what needs to be done.