feat(dot/rpc): Remove unused rpc method chain GetFinalizedHeadByRound #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimartiro
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
dimartiro
changed the title
P1sar
approved these changes
Feb 25, 2025
dimartiro
force-pushed
the
diego/remove-unused-getfinalisedheadbyround
branch
from
05f4ba3 to
4b61a84
Compare
timwu20
reviewed
Feb 25, 2025
timwu20
approved these changes
Feb 26, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I'm removing the RPC method
GetFinalizedHeadByRoundsince it is not defined as part of the standardThis will also help us to simplify the
BlockStateinterfaceChainModuleTests
make testIssues
Close: #4570