fix: establish RTT at start of connection #64
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A connection ping is required to establish the RTT - as implemented the ping only happens during the keep alive loop that doesn't kick in until after 30s by default. The change is to ping immediately on sinking a source - this means we are more likely to increase the send window on the remote which increases the amount of data they send and as such, throughput.
achingbrain
commented
Nov 13, 2023
| @@ -274,7 +274,7 @@ export class YamuxStream extends AbstractStream { | |||
| // then we (up to) double the recvWindow | |||
| const now = Date.now() | |||
| const rtt = this.getRTT() | |||
| if (flags === 0 && rtt > 0 && now - this.epochStart < rtt * 4) { | |||
| if (flags === 0 && rtt > -1 && now - this.epochStart < rtt * 4) { | |||
There was a problem hiding this comment.
RTT might be less than a ms on a very fast local connection?
🤷
achingbrain
commented
Nov 13, 2023
| @@ -45,9 +45,9 @@ describe('stream', () => { | |||
| // the window capacities should have refilled via window updates as received data was consumed | |||
|
|
|||
| // eslint-disable-next-line @typescript-eslint/dot-notation | |||
| expect(c1['sendWindowCapacity']).to.equal(defaultConfig.initialStreamWindowSize) | |||
| expect(c1['sendWindowCapacity']).to.be.gte(defaultConfig.initialStreamWindowSize) | |||
There was a problem hiding this comment.
These tests have become non-deterministic after this change, sometimes the window is the starting 256KB, sometimes it's been increased to 16MB by the time the test finishes.
|
I think this is one of the causes of the speed discrepancy between the js yamux and mplex implementations. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
wemeetagain
approved these changes
Nov 14, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
## [5.0.3](v5.0.2...v5.0.3) (2023-11-14) ### Bug Fixes * establish RTT at start of connection ([#64](#64)) ([672523b](672523b))
|
🎉 This PR is included in version 5.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A connection ping is required to establish the RTT - as implemented the ping only happens during the keep alive loop that doesn't kick in until after 30s by default.
The change is to ping immediately on sinking a source - this means we are more likely to increase the send window on the remote which increases the amount of data they send and as such, throughput.