-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add clientConfig to WS test #4299
Conversation
Your Render PR Server URL is https://web3-js-pr-4299.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c4s29os1nok4ouigmvi0. |
Pull Request Test Coverage Report for Build 1211808017
💛 - Coveralls |
process.env.INFURA_WSS, | ||
{ | ||
clientConfig: { | ||
maxReceivedFrameSize: 100000000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One message can fit into one or more(if message is fragmented) data frames as https://datatracker.ietf.org/doc/html/rfc6455#section-5.6 ,
The default values are maxReceivedFrameSize
1MiB and maxReceivedMessageSize
8MiB
https://github.com/theturtle32/WebSocket-Node/blob/a2cd3065167668a9685db0d5f9c4083e8a1839f0/docs/WebSocketClient.md#client-config-options
Both maxReceivedFrameSize
and maxReceivedMessageSize
are made here around 95.3 MiB, which will hinder fragmentation and multiplexing https://datatracker.ietf.org/doc/html/rfc6455#section-5.4 in case of huge message.
Plus It will not make ws connection fail safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As these are just the tests so be fine. But I agree with @jdevcs we should be using realistic values here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart form the point raised by @jdevcs LGTM.
I'm going to close this until we start to see the error pop up again, so that we can test with values other than |
We experience the issue mentioned in #3816 with our
e2e_windows
test suite, this aims to fix it