-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Create RequestManager and SubscriptionManager classes #4478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into nh/4429-request-manager
This was
linked to
issues
Oct 19, 2021
This pull request introduces 2 alerts when merging aef3292 into 4428570 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 6ff4afa into 09fc675 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging ff3bf0f into 09fc675 - view on LGTM.com new alerts:
|
spacesailor24
approved these changes
Oct 26, 2021
luu-alex
approved these changes
Oct 26, 2021
jdevcs
reviewed
Oct 27, 2021
jdevcs
reviewed
Oct 27, 2021
jdevcs
requested changes
Oct 27, 2021
jdevcs
reviewed
Oct 27, 2021
…s into nh/4429-request-manager
jdevcs
approved these changes
Oct 28, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create the implementation of
RequestManager
andSubscriptionManager
.Fixes #4429, #4430
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.