Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CandleStickChartRenderer drawDataSet method does not work with CombinedChartView #3673

Closed
1 task done
smwallace opened this issue Oct 2, 2018 · 1 comment
Closed
1 task done

Comments

@smwallace
Copy link

What did you do?

ℹ Created a CombinedChartView with a CandleStickChartRenderer to draw the candlesticks.

What did you expect to happen?

ℹ I expected the candle sticks to be drawn in the CombinedChartView.

What happened instead?

ℹ No candle sticks were drawn. The drawDataSetMethod incorrectly assumes that the chart is a CandleStickChartView, and in this case the chart is a CombinedChartView, so the drawDataSetMethod returns without drawing any candle sticks.

Charts Environment

Charts version/Branch/Commit Number: Version 3.2.0, installed via CocoaPods
Xcode version: Xcode Version 10.0 (10A255)
Swift version: Swift 4.0
Platform(s) running Charts: iOS
macOS version running Xcode: macOS High Sierra 10.13.6 (17G65)
Broken drawDataSet Method.txt

Demo Project

ℹ Please link to or upload a project we can download that reproduces the issue.
I have attached a file that shows the changes I made to fix the issue.

@liuxuan30
Copy link
Member

liuxuan30 commented Oct 24, 2018

seems it has been fixed recently. #3664

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants