Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SwiftAlgorithms Bitcode_disabled #4919

Closed
afridikhalid opened this issue Sep 15, 2022 · 6 comments
Closed

SwiftAlgorithms Bitcode_disabled #4919

afridikhalid opened this issue Sep 15, 2022 · 6 comments
Assignees
Milestone

Comments

@afridikhalid
Copy link

afridikhalid commented Sep 15, 2022

What did you do?

ℹ I did a pod update with charts '~> 4.1.0`

What did you expect to happen?

ℹ I expected that everything should work smoothly. but found out that Charts 4.1.0 has many breaking changes. which I have now updated everything. no more errors regarding Charts it self

What happened instead?

ℹ When I use Pods install it installs SwiftAlgorithms together with Charts 4.1.0 and that's when I try to run the project I get the error that SwiftAlgorithms should enable bitcode and I don't know how to change that.

Charts Environment

Charts version/Branch/Commit Number: 4.1.0
Xcode version: 14.0
Swift version: 5
Platform(s) running Charts: iOS

@afridikhalid
Copy link
Author

I had to iterate through all my targets and set ENABLED_BITCODE to true and now everything works :)

@areejsadaqa66
Copy link

I am still facing a problem with SwiftAlgorithms some files showing errors as: 'let' property 'base' may not be initialized directly; use "self. init(...)" or "self = ..." instead

and I tried to get all BITCODE to enable true and it still didn't work

@mugikhan
Copy link

mugikhan commented Sep 23, 2022

'let' property 'base' may not be initialized directly; use "self. init(...)" or "self = ..." instead

I am having the same issue as above

@tejua
Copy link

tejua commented Oct 5, 2022

I am having the same issue
did you find any solutions? @mugikhan @afridikhalid

@mabenhaddada
Copy link

This should help bypassing the issue until SwiftAlgorithms get updated to support new swift 5.7 I think !
To add at the end of your Podfile

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      if target.name == "SwiftAlgorithms"
        config.build_settings['BUILD_LIBRARY_FOR_DISTRIBUTION'] = 'NO'
      end
    end
  end
end

@pmairoldi
Copy link
Collaborator

Closed by #5069

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants