Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

temporary fix for o3-mini #6132

Merged
merged 2 commits into from
Feb 4, 2025
Merged

temporary fix for o3-mini #6132

merged 2 commits into from
Feb 4, 2025

Conversation

RetiredQQ
Copy link
Contributor

@RetiredQQ RetiredQQ commented Feb 2, 2025

πŸ’» ε˜ζ›΄η±»εž‹ | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

πŸ”€ ε˜ζ›΄θ―΄ζ˜Ž | Description of Change

πŸ“ θ‘₯充俑息 | Additional Information

Summary by CodeRabbit

  • New Features
    • Chat interactions now support additional model variants, resulting in more consistent responses and improved handling of system messages.
    • User interface icons have been updated to accurately reflect the active model type.
  • Chores
    • Model information has been refreshed to include updated metadata, ensuring alignment with the latest configuration details.

Copy link

vercel bot commented Feb 2, 2025

@RetiredQQ is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Feb 2, 2025

Walkthrough

The pull request updates the handling of model identification in several modules. The changes add conditions to account for models starting with "o3" in functions that filter models, set request parameters, and select icons. Additionally, the request payload logic now considers models starting with "o1" or "o3" for parameter defaults and timeout adjustments, and a new model entry ("o3-mini") is added to the knowledge cutoff mapping.

Changes

File(s) Change Summary
app/api/openai.ts, app/client/platforms/openai.ts, app/components/emoji.tsx Updated filtering and conditional logic to include models starting with "o3" (in addition to "o1"), affecting model retrieval, request payload parameters, message handling, and icon rendering.
app/constant.ts Added a new entry "o3-mini": "2023-10" to the KnowledgeCutOffDate record to support model-specific knowledge cutoff management.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ChatAPI as ChatGPTApi (openai.ts)
    participant RemoteAPI as OpenAI API

    User->>ChatAPI: Initiate chat request
    ChatAPI->>ChatAPI: Check if model starts with "o1" or "o3"
    ChatAPI->>ChatAPI: Set default parameters (temperature, penalties, timeout)
    ChatAPI->>RemoteAPI: Send chat request with updated parameters
    RemoteAPI-->>ChatAPI: Return response
    ChatAPI->>User: Return chat response
Loading
sequenceDiagram
    participant Caller
    participant ModelsAPI as getModels (openai.ts)
    participant RemoteService as Remote Model Service

    Caller->>ModelsAPI: Request available models
    ModelsAPI->>RemoteService: Fetch remote models list
    RemoteService-->>ModelsAPI: Send models array
    ModelsAPI->>ModelsAPI: Filter out models starting with "gpt-4", "chatgpt-4o", "o1", and "o3"
    ModelsAPI->>Caller: Return filtered models list
Loading

Possibly related PRs

Poem

I'm a little rabbit, hopping with glee,
New "o3" checks made, as clear as can be.
In code and in chat, precision is key,
With tweaks to the logic, it's smooth and free.
Carrots and code, a perfect harmony!
πŸ₯•πŸ‡βœ¨


πŸ“œ Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 1e20b64 and 4c4d44e.

πŸ“’ Files selected for processing (4)
  • app/api/openai.ts (1 hunks)
  • app/client/platforms/openai.ts (4 hunks)
  • app/components/emoji.tsx (1 hunks)
  • app/constant.ts (1 hunks)
πŸ”‡ Additional comments (8)
app/components/emoji.tsx (1)

41-42: LGTM! Consistent model handling.

The condition has been extended to include models starting with "o3", maintaining consistency with the model handling changes across the codebase.

app/api/openai.ts (1)

17-17: LGTM! Consistent model filtering.

The filtering logic has been extended to include models starting with "o3", maintaining consistency with the model handling changes across the codebase.

app/client/platforms/openai.ts (4)

198-198: LGTM! Clear and descriptive variable name.

The variable name isO1OrO3 clearly indicates its purpose of checking for both "o1" and "o3" models.


220-221: LGTM! Consistent message handling.

System role messages are skipped for both "o1" and "o3" models, maintaining consistent behavior.


229-232: LGTM! Consistent parameter handling.

Request parameters are consistently set for both "o1" and "o3" models:

  • temperature = 1
  • presence_penalty = 0
  • frequency_penalty = 0
  • top_p = 1

362-362: LGTM! Extended timeout for specific models.

The timeout duration is extended for both "o3" and "o1" models, similar to dalle3, which is appropriate given their potential processing requirements.

app/constant.ts (2)

413-413: LGTM! Knowledge cutoff date configured.

The knowledge cutoff date for "o3-mini" is set to "2023-10", consistent with other similar models like "o1-mini" and "o1-preview".


478-478: LGTM! Model added to available models.

The "o3-mini" model has been added to the list of available OpenAI models, making it accessible through the platform.

✨ Finishing Touches
  • πŸ“ Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Leizhenpeng Leizhenpeng merged commit 32b6090 into ChatGPTNextWeb:main Feb 4, 2025
1 check failed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants