Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

setScores: remove moreScoresExpected argument #37

Merged
merged 4 commits into from
Oct 5, 2023
Merged

setScores: remove moreScoresExpected argument #37

merged 4 commits into from
Oct 5, 2023

Conversation

juliangruber
Copy link
Member

@juliangruber juliangruber commented Oct 5, 2023 •
edited
Loading

Before:

[PASS] test_SetScores() (gas: 1590817)
[PASS] test_SetScoresEmptyRound() (gas: 1556720)
[PASS] test_SetScoresFractions() (gas: 1638722)
[PASS] test_SetScoresMultipleCalls() (gas: 2025617)
[PASS] test_SetScoresMultipleParticipants() (gas: 1672702)
[PASS] test_SetScoresNotEvaluator() (gas: 1524221)
[PASS] test_SetScoresTooBig() (gas: 1595467)
[PASS] test_SetScoresUnfinishedRound() (gas: 1522351)

After:

[PASS] test_SetScores() (gas: 1538608)
[PASS] test_SetScoresEmptyRound() (gas: 1533288)
[PASS] test_SetScoresFractions() (gas: 1590435)
[PASS] test_SetScoresMultipleCalls() (gas: 1996595)
[PASS] test_SetScoresMultipleParticipants() (gas: 1628208)
[PASS] test_SetScoresNotEvaluator() (gas: 1465824)
[PASS] test_SetScoresTooBig() (gas: 1624697)
[PASS] test_SetScoresUnfinishedRound() (gas: 1463951)

This actually reduces gas :) Great idea, @bajtos!

@juliangruber juliangruber requested a review from bajtos October 5, 2023 08:28
@juliangruber
Copy link
Member Author

hindsight please

@juliangruber juliangruber merged commit 8fb8618 into main Oct 5, 2023
@juliangruber juliangruber deleted the remove/more-scores-argument branch October 5, 2023 11:59
bajtos
bajtos reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two suggestions to consider.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bajtos bajtos bajtos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliangruber @bajtos