Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Closeable resource not closed #311

Closed
Dkhusainov opened this issue Apr 6, 2020 · 3 comments · Fixed by #316
Closed

Closeable resource not closed #311

Dkhusainov opened this issue Apr 6, 2020 · 3 comments · Fixed by #316
Labels
bug Something isn't working
Milestone
3.3.0

Comments

@Dkhusainov
Copy link

✍️ Describe the bug

Debug build with StrictMode detectLeakedClosableObjects reports leaked resource at
com.chuckerteam.chucker.api.ChuckerInterceptor$ChuckerTransactionTeeCallback.readResponseBuffer(ChuckerInterceptor.kt:253)

💣 Steps to reproduce

  1. add StrictMode.setVmPolicy(StrictMode.VmPolicy.Builder().detectAll().penaltyLog().build())
  2. make test requests

📱 Tech info

  • Chucker version: 3.2.0
@vbuberen vbuberen added the bug Something isn't working label Apr 6, 2020
@vbuberen
Copy link
Collaborator

vbuberen commented Apr 6, 2020

Thanks for reporting this issue.
Good catch!

@vbuberen
Copy link
Collaborator

vbuberen commented Apr 6, 2020

@MiSikora Should I leave it for you as for original feature creator?

@MiSikora
Copy link
Contributor

MiSikora commented Apr 6, 2020

Sure, I'll take a look and fix it when I find some time this week.

@MiSikora MiSikora mentioned this issue Apr 6, 2020
Merged
@ghost ghost added the Pending PR The resolution for the issue is in PR label Apr 6, 2020
@ghost ghost removed Pending PR The resolution for the issue is in PR bug Something isn't working labels Apr 6, 2020
@cortinico cortinico added the bug Something isn't working label Apr 7, 2020
@cortinico cortinico added this to the 3.3.0 milestone Apr 7, 2020
This was referenced Aug 5, 2020
Closed
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Close response file when it is no longer needed.
4 participants
@cortinico @Dkhusainov @vbuberen @MiSikora