Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add dark mode functionality #56

Closed
Abhijay007 opened this issue Jan 24, 2021 · 9 comments · May be fixed by #101
Closed

Add dark mode functionality #56

Abhijay007 opened this issue Jan 24, 2021 · 9 comments · May be fixed by #101
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Abhijay007
Copy link

Add dark mode functionality on the blog website

@ShreyaPrasad1209 ShreyaPrasad1209 added the good first issue Good for newcomers label Jun 12, 2021
@ShreyaPrasad1209 ShreyaPrasad1209 added the enhancement New feature or request label Jun 25, 2021
@astelrastogi
Copy link

I want to work on this issue

1 similar comment
@yashikajotwani12
Copy link

I want to work on this issue

@ShreyaPrasad1209
Copy link
Member

@yashikajotwani12 go ahead 👍🏻

@astelrastogi
Copy link

this is the link where i need to add the functionality right?
https://blog.circuitverse.org/

@AsherThomasBabu
Copy link

@ShreyaPrasad1209 I assume that the special event is done and the issue is available to other contributors?

I've written code in the theme/northendlab-hugo/layouts/partials folder locally, that adds the dark mode functionality. Upon trying to push the changes, I noticed that I cannot create a pull request for changes to the repo at CircuitVerse. Rather have to create a PR to the original repo at hugo-themes. Since this is a change that is specific to this project, I did not think doing this was right.

I'd be happy to receive input on how this issue can be solved.

@gouravmohanty7070
Copy link

Hey! Can I work on it?

@tachyons
Copy link
Member

tachyons commented Sep 3, 2021

Sorry, No. There is already a PR fir this

@AsherThomasBabu
Copy link

@tachyons, as suggested, I did open an issue on the templates' repository regarding adding a dark mode toggle, but did not receive any input there. What do you suggest we do for this now?

@ramlakshman2233
Copy link

I want to work for this .I guarantee you that I you will be satisified

@tachyons tachyons closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants