-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Show a spinner when the API request for Star an repo is running #266
Comments
Can I start workiing on this? |
cc : @vedant-jain03 |
Hey @Tanmoy741127, do you think it would be UI friendly if there was no spinner blocking the view? I have added a bool function which checks if the request is finished, and then only allows the user to star the project again, what are your views on that? |
@notbrood |
@Tanmoy741127 Regarding the bool function, I'm happy to create a PR for the function, and let someone else add the spinner. |
@notbrood in the mobile-app we are using Provider for state management solution and GetX is using for different purposes. So you can give it a try. |
Okay, I'll give it a try! |
I was able to, It looks UI Friendly as well! |
2023-03-08.03-56-08.mp4Here's how it looks! What are your views? |
Great ! Try to make the size same as the star icon |
I did, how does this look? 2023-03-08.13-28-40.mp4 |
It's looking good now ! |
Okay, I'm going to make a PR for this now! |
|
Is your feature request related to a problem? Please describe.
In the project details screen, we have options to star/unstar the repo. Now the issue is , we can tap the button multiple time in a short span of time. If user's internet connectivity is not too good, then this will create confusion and send many unnecessary requests to server.
Screenrecorder-2023-02-27-16-45-00-363.mp4
Describe the solution you'd like
To make that UI friendly, we can have a spinner, when the star/unstar function invoked, a spinner will be shown , as soon as the request executed successfully, we will remove spinner and update the state.
During the requesting time, we need to reject further requests.
Are you working on this? (Yes/No)
No
The text was updated successfully, but these errors were encountered: