Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Does this work on Windows? #21

Closed
CleanCut opened this issue Sep 16, 2022 · 2 comments
Closed

Does this work on Windows? #21

CleanCut opened this issue Sep 16, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@CleanCut
Copy link
Owner

It would be good if someone (not me 😆) would figure out if this utility works on Windows, and if not -- can we make it work without too much trouble?

@CleanCut CleanCut added the good first issue Good for newcomers label Sep 16, 2022
@CleanCut
Copy link
Owner Author

I tried enabling CI for windows, and 3 of 8 tests failed.

I don't know whether it's a problem with the tests, with headtail itself, or both. But it seems feasible that someone with Windows could get this working.

@tbmreza
Copy link
Contributor

tbmreza commented Oct 9, 2022

I can't reproduce what the CI is getting.

     Running tests\integration.rs (target\debug\deps\integration-8b71928931c7

running 8 tests
test head ... ok
test help ... ok
test argless ... ok
test head_length_exceeds_file_length ... ok
test overlapping_head_and_tail ... ok
test tail ... ok
test tail_length_exceeds_file_length ... ok
test follow_detects_recreation ... ok

test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.19s

I think I know where the failure is coming from. Windows treats line endings differently by default. https://stackoverflow.com/a/20653073
Pull request (trying this actions/checkout#135 (comment)) coming right up.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants