Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Vehicle part. Same label for different ids. Could be a mistake? #79235

Open
IdleSol opened this issue Jan 18, 2025 · 1 comment
Open

Vehicle part. Same label for different ids. Could be a mistake? #79235

IdleSol opened this issue Jan 18, 2025 · 1 comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@IdleSol
Copy link

IdleSol commented Jan 18, 2025

Describe the bug

I paid attention to:

Image

These are the variants for the vehicle door:


And for all the other doors that use copy-from.

Among the possible variants, there are different id's for which the same labels are set

{ "id": "front_left", "label": "Front Left", "symbols": "+", "symbols_broken": "&" },
{ "id": "front_right", "label": "Front Right", "symbols": "+", "symbols_broken": "&" },

{ "id": "ne", "label": "Front Right", "symbols": "+", "symbols_broken": "&" },
{ "id": "nw", "label": "Front Left", "symbols": "+", "symbols_broken": "&" },

I haven't looked into how it works. But I assume there is either unnecessary duplication or there must be different labels.

From the looks of it, they seem to be the same. But maybe that's just for one tileset. Or maybe I just don't see the difference.

Attach save file

n/a

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Versions and configuration

master

Additional context

No response

@IdleSol IdleSol added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jan 18, 2025
@IdleSol IdleSol changed the title Same label for different ids. Could be a mistake? Vehicle part. Same label for different ids. Could be a mistake? Jan 18, 2025
@marilynias
Copy link
Contributor

You could probably rename it to match the naming of

{ "id": "horizontal", "label": "Horizontal", "symbols": "\"", "symbols_broken": "0" },
{ "id": "cover_left", "label": "Cover Left", "symbols": "──│───│─", "symbols_broken": "0" },
{ "id": "cover_right", "label": "Cover Right", "symbols": "──│───│─", "symbols_broken": "0" },
{ "id": "nw", "label": "Front Left", "symbols": "┌┌└┘┘┘┐┌", "symbols_broken": "0" },
{ "id": "ne", "label": "Front Right", "symbols": "┐┐┌└└└┘┐", "symbols_broken": "0" },
{ "id": "sw", "label": "Rear Left", "symbols": "└└┘┐┐┐┌└", "symbols_broken": "0" },
{ "id": "se", "label": "Rear Right", "symbols": "┘┘┐┌┌┌└┘", "symbols_broken": "0" },
{ "id": "nw_edge", "label": "Front Left Corner", "symbols": "┌┌└┘┘┘┐┌", "symbols_broken": "0" },
{ "id": "ne_edge", "label": "Front Right Corner", "symbols": "┐┐┌└└└┘┐", "symbols_broken": "0" },
{ "id": "sw_edge", "label": "Rear Left Corner", "symbols": "└└┘┐┐┐┌└", "symbols_broken": "0" },
{ "id": "se_edge", "label": "Rear Right Corner", "symbols": "┘┘┐┌┌┌└┘", "symbols_broken": "0" },
{ "id": "left", "label": "Left", "symbols": "\\─/│\\─/", "symbols_broken": "0" },
{ "id": "right", "label": "Right", "symbols": "\\─/│\\─/", "symbols_broken": "0" },
{ "id": "vertical", "label": "Vertical", "symbols": "\\─/│\\─/", "symbols_broken": "0" },
{ "id": "vertical_left", "label": "Left Vertical", "symbols": "\\─/│\\─/", "symbols_broken": "0" },
{ "id": "vertical_right", "label": "Right Vertical", "symbols": "\\─/│\\─/", "symbols_broken": "0" },

though I'm not sure if those are equivalent.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

2 participants