Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unit-tests with CI Update #53

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Unit-tests with CI Update #53

merged 2 commits into from
Jun 20, 2020

Conversation

jakebolewski
Copy link
Contributor

@jakebolewski jakebolewski commented Jun 19, 2020 •
edited
Loading

closes #31

@charleskawczynski
Copy link
Member

Supersedes #51

@charleskawczynski
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 19, 2020

Configuration problem:
bors.toml: syntax error

charleskawczynski
charleskawczynski reviewed Jun 19, 2020
View reviewed changes
@jakebolewski
Copy link
Contributor Author

@charleskawczynski I don't think I have the permissions to disable the appveyor integration

@jakebolewski jakebolewski changed the title WIP: Work through CI update Unit-tests with CI Update Jun 19, 2020
@jakebolewski
Copy link
Contributor Author

Ok let's see if this works...

@charleskawczynski
Copy link
Member

I don't think I have the permissions to disable the appveyor integration

I can unhook it

@charleskawczynski
Copy link
Member

Actually, bors doesn't depend on appveyor, so it shouldn't hold anything up

@jakebolewski jakebolewski force-pushed the jcb/unittests branch 3 times, most recently from 71bbdc9 to b61d29b Compare June 19, 2020 23:43
@jakebolewski
Copy link
Contributor Author

👊 powershell

MicrosoftDocs/PowerShell-Docs#2361

@jakebolewski
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jun 19, 2020
@bors @jakebolewski
Merge #53
79340c0 
53: Unit-tests with CI Update r=jakebolewski a=jakebolewski



Co-authored-by: Melanie Bieli <melanie.bieli@bluewin.ch>
Co-authored-by: jakebolewski <jakebolewski@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 20, 2020

Build failed:

@jakebolewski
Copy link
Contributor Author

Yay! JuliaLinearAlgebra/MKL.jl#35

@jakebolewski
Copy link
Contributor Author

😞 JuliaPy/PyPlot.jl#315 (comment)

@jakebolewski
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 20, 2020

Build succeeded:

@bors bors bot merged commit 0d57d1f into master Jun 20, 2020
@bors bors bot deleted the jcb/unittests branch June 20, 2020 01:33
@jakebolewski jakebolewski mentioned this pull request Jun 20, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@charleskawczynski charleskawczynski charleskawczynski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakebolewski @charleskawczynski