Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BaseQueryParams.session_id is not used #271

Closed
Holi0317 opened this issue May 22, 2024 · 1 comment · Fixed by #281
Closed

BaseQueryParams.session_id is not used #271

Holi0317 opened this issue May 22, 2024 · 1 comment · Fixed by #281
Labels
bug Something isn't working

Comments

@Holi0317
Copy link
Contributor

Describe the bug

BaseQueryParams got an undocumented session_id that feels like it should override the session_id passed into createClient. But actually that field is never used and session_id is always using this.sessionId

session_id: this.sessionId,

Steps to reproduce

  1. Try to override session_id via BaseQueryParams

Expected behaviour

The session_id should be overridden

@slvrtrn
Copy link
Contributor

slvrtrn commented Jun 6, 2024

Fixed in 1.1.0. Also, session id override will be mentioned in the docs after ClickHouse/clickhouse-docs#2381 is merged.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants