Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Prepare for pending deprecation of .drop() from xarray, use drop_vars or others instead. #115

Open
brews opened this issue Jul 20, 2023 · 0 comments

Comments

@brews
Copy link
Member

brews commented Jul 20, 2023

Automated tests trigger loads of warnings about this. For e.g.

tests/test_input_damages.py::test_compute_ag_damages
  /Users/brewstermalevich/Projects/dscim/src/dscim/preprocessing/input_damages.py:426: PendingDeprecationWarning: dropping variables using `drop` will be deprecated; using drop_vars is encouraged.
    .drop("variable")

Should move the code away from using .drop() on xarray structures before this starts to throw errors.

@brews brews added bug Something isn't working and removed bug Something isn't working labels Jul 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant