-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Still getting deprecation warnings on Rails 5.1 #269
Comments
Ah, my mistake. It looks like that wasn't in 6.5.0. Any ETA on when a new version will be cut, at least to fix this issue? |
I'll cut the release this morning.
|
Thanks! |
If you have time to take a look at those failures and post a PR, fame and fortune will be yours for the taking. I won't be able to get to that today. And by "fame and fortune", I mean "a thank you for your time and effort will be added to the changelog." |
My recommendation (I don't have the time to make a PR right now, but I'll see what I can do) is to use t.references instead of t.integer for those foreign key columns. That should use the right integer type for the DB. |
I believe this is fixed on #262 but there hasn't been a new release after it being merged. I'm not getting the deprecation warning when using the git repo. |
release was cut and published last week. |
I'm still getting these, running on Rails 5.1.4, gem version is 6.6.0. |
Running Rails 5.1, closure_tree 6.5.0
Not sure why, but I'm still getting deprecation warnings such as:
These come when creating a model with
has_closure_tree
. When I comment out that line in the model, the deprecation warnings cease. I get a warning for each of the following methods:attribute_changed
attribute_changed?
changed
changes
There seems to be, at least on the master branch, already a workaround for
changes
in place but it doesn't seem to be triggering (yes my version of ActiveSupport is 5.1.0, I checked).The text was updated successfully, but these errors were encountered: