Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

QUESTION: Should the Home Screen have a scroll bar? #284

Closed
haleybear opened this issue Jun 23, 2020 · 5 comments · Fixed by #294
Closed

QUESTION: Should the Home Screen have a scroll bar? #284

haleybear opened this issue Jun 23, 2020 · 5 comments · Fixed by #294
Assignees

Comments

@haleybear
Copy link

I have an iPhone 8 that I am using for testing and the main view of the home screen looked off until I realized that it was because there is a scroll bar for the two options. Is this supposed to happen on this screen?
image

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 23, 2020

Let's optimize this layout so it looks good on all screen sizes. A possibility would be a combination of the approaches that have been implemented so far: Aspect-ratio based cell height, but with a higher prio "smaller than" constraint for the height. This way on bigger screens (e.g. iPad) the cells don't take up nearly half of the screen's height.

Or ask UX.

@haleybear
Copy link
Author

@i-schuetz that sounds fair, I noticed that one of the things that is helping the Android version is that the "Symptom Reporting" and "Exposure Alerts" text is on a single line, would that help here though?
image

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 23, 2020

Not directly, as on iOS the cell's height is fixed currently.

@Sam-gtri can you ask design what they want? It's btw important to keep in mind that we may have more than 2 items, in which case adjusting these 2 cells will not be very useful. But they may also say that for the foreseeable future it will be 2, in which case it's ok to optimize for it.

@Sam-gtri
Copy link
Contributor

@i-schuetz Who is in charge of design?

@ivnsch
Copy link
Collaborator

ivnsch commented Jun 23, 2020

@Sam-gtri sorry! That should have been @astewart43-gtri (I'd ask in the UX channel).

@ivnsch ivnsch assigned ivnsch and unassigned astewart43-gtri Jun 29, 2020
@ivnsch ivnsch linked a pull request Jun 29, 2020 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants