Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use smaller rlp package #13

Open
majecty opened this issue Oct 10, 2019 · 3 comments
Open

Use smaller rlp package #13

majecty opened this issue Oct 10, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@majecty
Copy link
Contributor

majecty commented Oct 10, 2019

We are importing the whole Go Ethereum code to use the RLP code.
We should import only the RLP code.

@cubismic
Copy link
Member

go get github.com/ethereum/go-ethereum/rlp will download whole source code of go-ethereum.
The codes are saved in $GOPATH/pkg/github.com/ethereum/go-ethereum.
And when I import only rlp like 5cea778#diff-b22bd1d77f068190b14a8488f1e7c21b, golang only includes rlp package while compiling.

My point is, is this really could be a problem? I think downloading only rlp folder to the $GOPATH looks odder.

@majecty
Copy link
Contributor Author

majecty commented Oct 11, 2019

Thanks for explaining how the import is working.
Although other parts of Go Ethereum code is not compiled, downloading a huge code base that is not used is a problem.

@majecty majecty added the help wanted Extra attention is needed label Nov 5, 2019
@majecty
Copy link
Contributor Author

majecty commented Nov 5, 2019

@gurrpi You can try this issue.
We don't know how the Golang import is working.
So we are not confident that using Go-Ethereum's rlp package is good or bad.
IMO importing a small package in a big repository is not a recommended practice. Because a user that using CodeChain Go SDK may download the big repository to use the library.

Do you know the Golang users' convention about using a small package in a big repository?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants