Skip to content

Sync does not work on a fork including the same tx #736

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
hyunsikjeong opened this issue Sep 19, 2018 · 3 comments · Fixed by #741
Closed

Sync does not work on a fork including the same tx #736

hyunsikjeong opened this issue Sep 19, 2018 · 3 comments · Fixed by #741
Assignees
@hyunsikjeong
Labels
bug Something isn't working sync

Comments

@hyunsikjeong
Copy link
Contributor

Think about the situation that one node created block A with parcel a and another node created block A' with parcel a. If one of these two nodes takes the lead, the other node should be synchronized to the leading one, but it will fail because of ParcelAlreadyImported on parcel a.
It also happens on the same transaction.
@hyunsikjeong hyunsikjeong added bug Something isn't working sync labels Sep 19, 2018
@hyunsikjeong hyunsikjeong self-assigned this Sep 19, 2018
@hyunsikjeong hyunsikjeong changed the title Sync does not work with a fork including the same parcel/tx Sync does not work on a fork including the same parcel/tx Sep 19, 2018
@hyunsikjeong hyunsikjeong mentioned this issue Sep 19, 2018
Merged
@hyunsikjeong
Copy link
Contributor Author

It doesn't happen with the same parcel.

@hyunsikjeong hyunsikjeong changed the title Sync does not work on a fork including the same parcel/tx Sync does not work on a fork including the same tx Sep 19, 2018
@joojis joojis mentioned this issue Sep 19, 2018
Closed
4 tasks
@hyunsikjeong
Copy link
Contributor Author

Fixed in #737

@hyunsikjeong
Copy link
Contributor Author

I thought that it's better to open the new issue for it, but I think it can be discussed in this issue.
If there's the same transaction in two nodes with different invoice that one node has success, the other one has fail, those two nodes are not synchronized well so the node which has the fail invoice will return null for asking the invoice of the transaction.
c637b9b#diff-2c230a4f9a1ccf73af73889e72b753eeR295

@hyunsikjeong hyunsikjeong reopened this Sep 19, 2018
@sgkim126 sgkim126 mentioned this issue Sep 20, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hyunsikjeong hyunsikjeong

Labels
bug Something isn't working sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the bug that transaction invoice becomes invalid after reorganization
1 participant
@hyunsikjeong